Skip to content

Added github action to validate feature catalog files #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Apr 3, 2025

Motivation

This PR adds a new github action workflow which reuses a workflow introduced in the PR in the localstack/meta repository. A new workflow validates files containing descriptions of AWS services (aka. feature catalog YAML files).

Changes

Once this workflow is merged, it will provide the following functionality:

  • Check that the features.yml file is present alongside the provider file (provider.py) whenever a file within the specific service is changed
  • Validate any updated features.yml files against the JSON schema defined in the localstack/meta repository.

@k-a-il k-a-il self-assigned this Apr 3, 2025
@k-a-il k-a-il added this to the Playground milestone Apr 3, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label Apr 3, 2025
@k-a-il k-a-il marked this pull request as ready for review April 3, 2025 11:38
@k-a-il k-a-il requested review from silv-io and sannya-singal and removed request for dfangl April 3, 2025 11:38
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The re-usable workflow really makes it easy to transfer between repos :)

Copy link
Contributor

@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 Changes LGTM 👍

@k-a-il k-a-il merged commit 6dc9c54 into master Apr 8, 2025
22 of 23 checks passed
@k-a-il k-a-il deleted the feature-catalog-gh-action branch April 8, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants