Admin: Use cryptography instead of OpenSSL #12476
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 53m 48s ⏱️ +32s For more details on these failures, see this check. Results for commit 523f899. ± Comparison against base commit 9e84b8d. ♻️ This comment has been updated with latest results. |
|
This is dependent on getmoto/moto#8761 being part of Moto-ext - will revisit this once that's merged. |
8015bb9 to
523f899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The PyOpenSSL module explicitly suggests that users should use the standard
cryptographymodule instead.As far as I can tell, all SSL-related functions within LocalStack (Pro) now use
cryptography, so this both simplifies the implementation, and reduces the mental load for developers.I was hoping to be able to remove the dependency as well, just to make LocalStack's footprint a little smaller, but unfortunately
twistedstill uses it. 😢