Skip to content

Bump moto-ext to 5.1.3.post1 #12499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Bump moto-ext to 5.1.3.post1 #12499

merged 2 commits into from
Apr 17, 2025

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Apr 8, 2025 •
edited
Loading

Summary

This PR bumps moto-ext to 5.1.3.post1.

Note

The last few moto-ext bumps were heavily cherry picked to omit certain incompatible changes. The affected components have been fixed, so this release brings everything up-to-date with Moto upstream.

To do

  • Ext compatibility (Ext integration tests) Ext Integration Tests # 4218 (relevant fixes in the companion branch. failures don't seem to be related and are observed in other pipelines)
FAILED tests/aws/services/cloudformation/resources/test_customresources.py::test_customresource_lambda_backed - AssertionError: assert 'custom-data' == 'unknown'
FAILED tests/aws/services/cloudformation/resources/test_customresources.py::test_customresource_sns_backed - AssertionError: assert 'custom-data' == 'unknown'
FAILED tests/aws/services/cloudformation/resources/test_customresources.py::test_update_custom_resource - json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

@viren-nadkarni viren-nadkarni self-assigned this Apr 8, 2025
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Apr 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   8m 29s ⏱️
488 tests 438 ✅  50 💤 0 ❌
976 runs  876 ✅ 100 💤 0 ❌

Results for commit b490312.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 54m 53s ⏱️ + 1m 8s
4 368 tests ±0  4 014 ✅ ±0  354 💤 ±0  0 ❌ ±0 
4 370 runs  ±0  4 014 ✅ ±0  356 💤 ±0  0 ❌ ±0 

Results for commit b490312. ± Comparison against base commit 3936886.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review April 17, 2025 08:04
@viren-nadkarni viren-nadkarni requested review from alexrashed and removed request for simonrw, dominikschubert and pinzon April 17, 2025 08:04
alexrashed
alexrashed approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping moto(-ext) up to date! Nice and clean upgrade, well tested! 💯

@viren-nadkarni viren-nadkarni merged commit 9e84b8d into master Apr 17, 2025
54 checks passed
@viren-nadkarni viren-nadkarni deleted the bump-moto-ext-5.1.3 branch April 17, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viren-nadkarni @alexrashed