Skip to content

KMS: enable _custom_key_material_ for ECC keys #12504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

KMS: enable _custom_key_material_ for ECC keys #12504

merged 2 commits into from
Apr 10, 2025

Conversation

sannya-singal
Copy link
Contributor

@sannya-singal sannya-singal commented Apr 9, 2025 •
edited
Loading

Motivation

This PR fixes an issue where custom key material provided via the _custom_key_material_ tag during kms create-key for ECC keys is ignored.

Closes #11678

Changes

Enables _custom_key_material_ for ECC keys and verifies the implementation using a test with ECC_SECG_P256K1 key specification.

@sannya-singal sannya-singal added aws:kms AWS Key Management Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Apr 9, 2025
@sannya-singal sannya-singal added this to the 4.4 milestone Apr 9, 2025
@sannya-singal sannya-singal self-assigned this Apr 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   4m 23s ⏱️ - 1h 48m 49s
672 tests  - 3 654  665 ✅  - 3 317  7 💤  - 337  0 ❌ ±0 
674 runs   - 3 654  665 ✅  - 3 317  9 💤  - 337  0 ❌ ±0 

Results for commit 9892747. ± Comparison against base commit 6dc9c54.

This pull request removes 3655 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.kms.test_kms.TestKMS ‑ test_create_custom_key_asymmetric

♻️ This comment has been updated with latest results.

@sannya-singal sannya-singal marked this pull request as ready for review April 9, 2025 06:32
@sannya-singal sannya-singal requested review from silv-io and k-a-il April 9, 2025 06:32
silv-io
silv-io approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

k-a-il
k-a-il approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sannya-singal sannya-singal merged commit 587ffca into master Apr 10, 2025
31 checks passed
@sannya-singal sannya-singal deleted the custom-key branch April 10, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

@k-a-il k-a-il k-a-il approved these changes

Assignees

@sannya-singal sannya-singal

Labels
aws:kms AWS Key Management Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

bug: _custom_key_material_ does not seem to work for SECP256k1
3 participants
@sannya-singal @silv-io @k-a-il