apply fix for podman container labels dict #12526
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Thanks @TheWolfNL for taking this over! Sadly your PR also has a linting error, could you fix those issues (using make format, for example) to get the CI to pass?
Should be fixed now 👍🏻 |
There was a problem hiding this comment.
One more change to make it python 3.9 compatible, I just discovered it by running more workflows.
Another thing: You have been committing with an email address linked to one github account, but created the PR and signed the CLA with the other. This leads to the CLA bot to complain, currently. Could you either sign the CLA with the other account as well (just comment here), or change the email in the commits to another one connected to the other account, and force push from the @TheWolfNL account? This would make the PR fully green :)
localstack-core/localstack/utils/container_utils/docker_cmd_client.py
Outdated
Show resolved
Hide resolved
|
I have read the CLA Document and I hereby sign the CLA |
|
@dfangl do you happen to know when a new release is planned? I could not find any info regarding a release schedule of sorts. |
|
Hi @TheWolfNL |
Motivation
The existing PR seems to be waiting on a small change, so to speed up the process I made the change here.
Related Bug report
Changes
When invoking _transform_container_labels, I added a check to veryify is the supplied parameter is already a Dict, which is the default in Podman. if so return the Dict, otherwise split the string and transform it into a Dict as usual.
semver: patch