Skip to content

CloudFormation Engine v2: Base Mappings and Conditions tests for Update Graph and PreProc #12527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

CloudFormation Engine v2: Base Mappings and Conditions tests for Update Graph and PreProc #12527

merged 1 commit into from
Apr 15, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 15, 2025

Motivation

This PR introduces foundational boundary tests for computing update graphs and pre-processing CloudFormation template updates that involve changes to Mappings and Conditions. Additionally, it enhances the resource pre-processing logic to more accurately handle the addition and removal of both positive and negative conditions across updates.

Changes

  • base boundary tests for updates with Mappings and Conditions changes
  • improve the preprocessing of resources by handling the introduction or removal of conditions

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 15, 2025
@MEPalma MEPalma self-assigned this Apr 15, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   20m 53s ⏱️ - 1h 35m 43s
462 tests  - 3 898  314 ✅  - 3 700  148 💤  - 198  0 ❌ ±0 
464 runs   - 3 898  314 ✅  - 3 700  150 💤  - 198  0 ❌ ±0 

Results for commit 7c04b3b. ± Comparison against base commit 8b4774f.

This pull request removes 3908 and adds 10 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_add_new_negative_condition_to_existent_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_add_new_positive_condition_to_existent_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_update_adds_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_update_removes_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_addition_with_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_deletion_with_resource_remap
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_addition_with_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_deletion_with_resource_remap
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_update
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_leaf_update
This pull request removes 208 skipped tests and adds 10 skipped tests. Note that renamed tests count towards both. 
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input4-FAILED]
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_deployed_infra_state
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_populate_data
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_user_clicks_are_stored
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_get_api_case_insensitive
tests.aws.services.apigateway.test_apigateway_api.TestApigatewayIntegration ‑ test_put_integration_request_parameter_bool_type
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_authorizer_crud
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_http_integration_with_path_request_parameter
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration[/lambda/foo1]
…

tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_add_new_negative_condition_to_existent_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_add_new_positive_condition_to_existent_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_update_adds_resource
tests.aws.services.cloudformation.v2.test_change_set_conditions.TestChangeSetConditions ‑ test_condition_update_removes_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_addition_with_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_deletion_with_resource_remap
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_addition_with_resource
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_deletion_with_resource_remap
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_key_update
tests.aws.services.cloudformation.v2.test_change_set_mappings.TestChangeSetMappings ‑ test_mapping_leaf_update

@MEPalma MEPalma merged commit 2ec3574 into master Apr 15, 2025
34 checks passed
@MEPalma MEPalma deleted the MEP-CFN-update_graph_test_driven_imp branch April 15, 2025 18:51
simonrw
simonrw approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these extra tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw