CFn v2: support outputs #12536
Merged
CFn v2: support outputs #12536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
484cf82 to
451f836
Compare
LocalStack Community integration with Pro 2 files 2 suites 20m 47s ⏱️ Results for commit 271ec4c. ♻️ This comment has been updated with latest results. |
6b187b5 to
b07c444
Compare
MEPalma
reviewed
Apr 24, 2025
| "Outputs": [ | ||
| # TODO(parity): Description, ExportName | ||
| # TODO(parity): what happens on describe stack when the stack has not been deployed yet? | ||
| {"OutputKey": k, "OutputValue": v} |
There was a problem hiding this comment.
We could instantiate these as localstack.aws.api.cloudformation.Output
| @@ -27,10 +30,18 @@ | |||
| LOG = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class ChangeSetModelExecutorResult: | |||
| resources: dict | |||
There was a problem hiding this comment.
Moving forward we could think of typing these
There was a problem hiding this comment.
I want to do a proper typing pass when everything has settled 👍 A big issue with the old provider is lack of types
b07c444 to
b111505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the preprocessor supports evaluating outputs, but the executor does not use these values.
Changes
executemethod to return a structured value which includes the stack outputs