Skip to content

Clarify coverage error messages to distinguish license and emulation limits #12547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 23, 2025

Motivation

By refining our coverage error messages to explicitly distinguish between license-plan restrictions and missing LocalStack emulation, developers immediately know whether they need to upgrade or await feature support. This is especially valuable for integrated services like Step Functions, where missing or unlicensed services defined in the state machines can result in evaluation failure.

Changes

  • Error for service action limitations rewritten from
    API action <action-name> for service <service-name> not yet implemented or pro feature - please check https://docs.localstack.cloud/references/coverage/coverage_s3/ for further information
    to
    The API action <action-name> for service <service-name> is either not available in your current license plan or has not yet been emulated by LocalStack. Please refer to https://docs.localstack.cloud/references/coverage/coverage_<service-name> for more information.

  • Error for service limitations rewritten from
    API for service <service-name> not yet implemented or pro feature - please check https://docs.localstack.cloud/references/coverage/ for further information
    to
    The API for service <service-name> is either not included in your current license plan or has not yet been emulated by LocalStack. Please refer to https://docs.localstack.cloud/references/coverage for more details.

Future Work

Extend these error messages to suggest the specific license tier required to enable a given service or API action, or to clearly indicate when the requested service isn’t supported by LocalStack

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 23, 2025
@MEPalma MEPalma added this to the 4.4 milestone Apr 23, 2025
@MEPalma MEPalma requested a review from lukqw April 23, 2025 08:16
@MEPalma MEPalma self-assigned this Apr 23, 2025
@MEPalma MEPalma requested a review from thrau as a code owner April 23, 2025 09:10
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 54m 14s ⏱️ +8s
4 375 tests ±0  4 018 ✅ ±0  357 💤 ±0  0 ❌ ±0 
4 377 runs  ±0  4 018 ✅ ±0  359 💤 ±0  0 ❌ ±0 

Results for commit 8231ea2. ± Comparison against base commit 77f30dc.

@MEPalma MEPalma requested review from silv-io and removed request for thrau April 23, 2025 12:07
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is correct for our current licensing and will be more correct for our future licensing as well.

f"API %sfor service '%s' not yet implemented or pro feature"
f" - please check {COVERAGE_LINK_BASE}%s for further information"
)
_COVERAGE_LINK_BASE = "https://docs.localstack.cloud/references/coverage"
Copy link
Member

@silv-io silv-io Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link will probably be replaced by the feature catalog in the future, but for now it's the only thing we have.

/cc @k-a-il for the future, when this will have to change

@MEPalma MEPalma merged commit 49dcd93 into master Apr 23, 2025
31 checks passed
@MEPalma MEPalma deleted the MEP-minor_coverage_docs branch April 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants