Skip to content

Step Functions: Fix Mock Test for Multi-Region #12562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Step Functions: Fix Mock Test for Multi-Region #12562

merged 1 commit into from
Apr 29, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 29, 2025 •
edited
Loading

Motivation

The mocked integration test at aws.services.stepfunctions.v2.mocking.test_base_scenarios.TestBaseScenarios.test_lambda_invoke introduced in e8b8794 is not compatible with multi-region test runs; these changes resolve this incompatibility.

Changes

  • Insert the test environment's region name into this mock ARN to maintain snapshot compatibility across multi-region tests

Testing

@MEPalma MEPalma added this to the 4.4 milestone Apr 29, 2025
@MEPalma MEPalma self-assigned this Apr 29, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 29, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   21m 22s ⏱️ - 1h 22m 38s
1 487 tests  - 2 906  1 414 ✅  - 2 618  73 💤  - 288  0 ❌ ±0 
1 489 runs   - 2 906  1 414 ✅  - 2 618  75 💤  - 288  0 ❌ ±0 

Results for commit d4a4b57. ± Comparison against base commit d80eef7.

This pull request removes 2906 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@MEPalma MEPalma changed the title [draft] Step Functions: Fix Mock Test for Multi-Region Step Functions: Fix Mock Test for Multi-Region Apr 29, 2025
@MEPalma MEPalma marked this pull request as ready for review April 29, 2025 08:13
gregfurman
gregfurman approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MEPalma MEPalma merged commit 936c697 into master Apr 29, 2025
37 of 38 checks passed
@MEPalma MEPalma deleted the MEP-SFN-fix_mock_test_multiregion branch April 29, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@gregfurman gregfurman gregfurman approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @joe4dev @gregfurman