remove usage analytics module #12573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of deprecated usage.aggregate()
53426fb to
b894de6
Compare
| @@ -153,4 +153,4 @@ def get_host_kernel_version() -> str: | |||
|
|
|||
|
|
|||
| def get_usage(): | |||
| return usage.aggregate() | |||
| return MetricRegistry().collect() | |||
There was a problem hiding this comment.
note: tested by calling the following endpoints
alexrashed
approved these changes
May 5, 2025
simonrw
pushed a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
usage.pymodule has been deprecated and is no longer in use. All services and features that previously relied on it have been fully migrated to the newmetrics.pymodule.Given that the transition is now complete, we can safely remove the
usage.pymodule along with its associated unit tests.Changes