Migrate MA/MR pipeline from CircleCI to GH Actions #12579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
approved these changes
May 7, 2025
|
|
||
| env: | ||
| IMAGE_NAME: "localstack/localstack" | ||
| TINYBIRD_DATASOURCE: "community_tests_circleci_ma_mr" |
There was a problem hiding this comment.
nit: Would change this to simply community_tests_ma_mar but this will be handled by me either way in the PR handling tinybird upload
k-a-il
requested changes
May 7, 2025
Comment on lines
+6
to
+9
| pull_request: | ||
| paths: | ||
| - '.github/workflows/aws-tests-mamr.yml' | ||
| - '.github/workflows/aws-tests.yml' |
k-a-il
approved these changes
May 7, 2025
simonrw
pushed a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is part of the ongoing initiative to migrate our CI/CD workflows from CircleCI to GitHub Actions.
Specifically, it introduces a multi-region and multi-account test execution workflow. It reuses the full-run test suite introduced in #12545 and enhances it by generating randomized AWS Account IDs and Regions.
Changes
.github/workflows/aws-tests-mamr.ymlfor executing full-run tests with randomised AWS credentials.TEST_AWS_ACCOUNT_ID,TEST_AWS_ACCESS_KEY_IDandTEST_AWS_REGION_NAME.Prepare Local Test Environment..github/workflows/aws-tests.ymlto add values for region, account id and access key id and set the defaults from config.py.Testing
Successful Workflow: https://github.com/sannya-singal/localstack/actions/runs/14856442816/job/41711348012.
Note: This skips docker client tests in class
TestDockerClient: here andtest_create_with_exposed_ports: here)Screenshots
Random credentials being used for the testing of the workflow:
Successful Workflow Run: