Skip to content

Docker registry customisation #12590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 7, 2025

Motivation

Some customers work in airgapped environments, and require customisation of the Docker image registries used. This PR enables a flexible method for adding customisation to the Docker image pulling strategy.

Changes

  • Introduce the RegistryResolverStrategy protocol to support custom image resolving
  • Add an implementation HardCodedResolver which is a no-op
  • Use this resolver when pulling images, or creating containers

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 7, 2025
@simonrw simonrw added this to the 4.5 milestone May 7, 2025
Copy link

github-actions bot commented May 7, 2025

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   8m 23s ⏱️ -48s
495 tests ±0  445 ✅ ±0   50 💤 ±0  0 ❌ ±0 
990 runs  ±0  890 ✅ ±0  100 💤 ±0  0 ❌ ±0 

Results for commit 069cfcf. ± Comparison against base commit 6f6b50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 7, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 41m 40s ⏱️ +26s
4 469 tests ±0  4 080 ✅ ±0  389 💤 ±0  0 ❌ ±0 
4 471 runs  ±0  4 080 ✅ ±0  391 💤 ±0  0 ❌ ±0 

Results for commit 069cfcf. ± Comparison against base commit 6f6b50e.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the docker/global-registry-customisation branch from 0e5586f to a484b00 Compare May 15, 2025 14:44
@simonrw simonrw force-pushed the docker/global-registry-customisation branch from a484b00 to 069cfcf Compare May 30, 2025 10:28
Copy link

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 20s ⏱️ +2s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 069cfcf. ± Comparison against base commit 6f6b50e.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 38s ⏱️ +30s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 069cfcf. ± Comparison against base commit 6f6b50e.

Copy link

Test Results - Alternative Providers

597 tests   420 ✅  14m 54s ⏱️
  4 suites  177 💤
  4 files      0 ❌

Results for commit 069cfcf.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 3s ⏱️
4 824 tests 4 282 ✅ 542 💤 0 ❌
4 830 runs  4 282 ✅ 548 💤 0 ❌

Results for commit 069cfcf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant