Defer CDK imports in infra provisioning #12591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
May 7, 2025
There was a problem hiding this comment.
Great catch! Thanks a lot for jumping on this! Absolutely great to fix this issue, speeding up our own development cycles / improving our own DevX! 💯 🦸🏽
I added @bblommers as reviewer to quickly give his sentiment on the mypy change / issue.
| @@ -85,6 +84,8 @@ def cdk_template_path(): | |||
| # Note: Don't move this into testing lib | |||
| @pytest.fixture(scope="session") | |||
| def infrastructure_setup(cdk_template_path, aws_client): | |||
| from localstack.testing.scenario.provisioning import InfraProvisioner | |||
There was a problem hiding this comment.
nitpick (non-blocking): I think it would make sense to add a comment here explaining why it is important to have this import deferred. :)
There was a problem hiding this comment.
Ah, I meant to do that and got distracted, will add!
b4a6071 to
adc30c6
Compare
bblommers
approved these changes
May 7, 2025
|
LGTM! As long as |
simonrw
pushed a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we import the
localstack.testing.scenario.provisioningmodule on every pytest run, which in turns imports the aws_cdk python bindings.This leads to a heavy increase in startup time, especially when debugging (tested in Pycharm).
By deferring the import to the first fixture usage, instead of on all imports, that increased delay will only happen for tests actually requesting the fixture, instead of all tests.
For unrelated tests, this can reduce the start time of the test (on my system):
CI runtime should only marginally be affected, only if test selection selects tests without a single usage of the infra provisioner.
I also fixed the mypy precommit errors happening on my system, by ignoring the plux import completely, instead of just ignoring import-untyped errors.
Changes