Skip to content

CFn v2: Skip media type assertion #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

CFn v2: Skip media type assertion #12597

merged 1 commit into from
May 8, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 8, 2025 •
edited
Loading

Motivation

The commit that introduced the parity fixes for CFn (#12589) ported over the APIGW tests from v1. Unfortunately the CI was not run before #12586 was merged, and the merge commit of the PR only ran acceptance tests meaning that this is a ticking time bomb that's going to fail the pipeline overnight.

Thanks @tiurin for spotting this

Changes

  • Skip new field binaryMediaTypes in the APIGW CFn test

@simonrw
Skip media type assertion
5ebff4a 
This change was added in between test completion and merging of the PR
it came from
@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 8, 2025
@simonrw simonrw self-assigned this May 8, 2025
@simonrw simonrw marked this pull request as ready for review May 8, 2025 16:35
@simonrw simonrw requested a review from tiurin May 8, 2025 16:35
@simonrw simonrw assigned tiurin and unassigned simonrw May 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 8s ⏱️ - 1h 22m 30s
490 tests  - 3 935  315 ✅  - 3 727  175 💤  - 208  0 ❌ ±0 
492 runs   - 3 935  315 ✅  - 3 727  177 💤  - 208  0 ❌ ±0 

Results for commit 5ebff4a. ± Comparison against base commit a7b4250.

This pull request removes 3935 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@tiurin tiurin merged commit 8ec9293 into master May 8, 2025
46 checks passed
@tiurin tiurin deleted the cfn/v2/skip-binary-media-types branch May 8, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiurin tiurin tiurin approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@pinzon pinzon Awaiting requested review from pinzon

Assignees

@tiurin tiurin

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @tiurin