Improve security group fixture for EC2 #12607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
approved these changes
May 13, 2025
| GroupName=kwargs["GroupName"], | ||
| IpPermissions=permissions, | ||
| ) | ||
| if "VpcId" not in kwargs: |
There was a problem hiding this comment.
Could you elaborate in a comment why the special cases are required?
There was a problem hiding this comment.
I actually got rid of the condition at all. We can use the GroupId always (but we could use GroupName for the default VPC only)
Default security group can use GroupName instead of the GroupId, but
the latter works in all cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on snapshotted tests, I wanted to have the possibility to pass to
ec2_create_security_groupan IP protocol for the ingress permissions.I also noticed that this fixture is also duplicated in the ELB test (I removed it in the linked PR);
Changes
ip_protocolto the fixture's factory function;