-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add reporting to Tinybird for new GitHub Actions pipelines #12610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d8a98c
to
782eb58
Compare
782eb58
to
2842b33
Compare
2842b33
to
7603f71
Compare
298817a
to
43e700e
Compare
eee53ef
to
6c3ab45
Compare
@@ -152,6 +154,24 @@ jobs: | |||
make publish || echo "dev release failed (maybe it is already published)" | |||
fi | |||
|
|||
push-to-tinybird: | |||
name: Push Workflow Status to Tinybird | |||
if: always() # && github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this part # && github.ref == 'refs/heads/master'
commented out? do you plan to enable it for the master branch only once we're ready to switch to GitHub Actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was too eager to merge right now and forgot to revert those changes, will do a quick follow-up PR 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 🚀 Great to see reporting to tinybird in the main pipeline
Motivation
This PR is part of the initiative to switch to GitHub Actions in the test suite of this repository. It adds reporting to tinybird of the workflow and test results.
Changes
Testing
Run the different workflows (full, acceptance, mamr) and make sure the tinybird report goes through. Also check the dashboard for existence of the workflows
TODO
What's left to do: