Skip to content

Add Workflow Summaries #12619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025
Merged

Add Workflow Summaries #12619

merged 7 commits into from
May 20, 2025

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented May 14, 2025

Motivation

For nicer usability, we can add workflow summaries for the test runs so that we can quickly find which tests are failing

Changes

  • Add test summaries for Preflight/Unit-Tests, Integration/Bootstrap Tests, Acceptance Tests, and Alternative Provider Tests
  • Add a marker for MA/MR to be able to distinguish

Testing

Check the auto-generated messages below for correctness (I've deleted some of the old ones which did not fit the proper scheme yet)

TODO

What's left to do:

  • Integration Tests
  • Acceptance Tests
  • Alternative Provider Tests

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label May 14, 2025
@silv-io silv-io force-pushed the add-workflow-summaries branch from cba002e to 3b5ed55 Compare May 19, 2025 13:45
Copy link

github-actions bot commented May 19, 2025

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   8m 29s ⏱️
495 tests 445 ✅  50 💤 0 ❌
990 runs  890 ✅ 100 💤 0 ❌

Results for commit f2140ee.

♻️ This comment has been updated with latest results.

@silv-io silv-io force-pushed the add-workflow-summaries branch from e8dc64c to e3d6b35 Compare May 19, 2025 14:20
@localstack localstack deleted a comment from github-actions bot May 19, 2025
@localstack localstack deleted a comment from github-actions bot May 19, 2025
@localstack localstack deleted a comment from github-actions bot May 19, 2025
@localstack localstack deleted a comment from github-actions bot May 19, 2025
Copy link

github-actions bot commented May 19, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 16s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit f2140ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 19, 2025

Test Results (MA/MR) - Alternative Providers

587 tests   407 ✅  14m 41s ⏱️
  4 suites  180 💤
  4 files      0 ❌

Results for commit f2140ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 19, 2025

Preflight- & Unit-Test Results

21 601 tests   19 955 ✅  6m 12s ⏱️
     1 suites   1 646 💤
     1 files         0 ❌

Results for commit e3d6b35.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 19, 2025

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 5s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit f2140ee.

♻️ This comment has been updated with latest results.

@silv-io silv-io marked this pull request as ready for review May 19, 2025 14:57
Copy link

github-actions bot commented May 19, 2025

Test Results (MA/MR) - Preflight, Unit

21 601 tests   19 955 ✅  6m 13s ⏱️
     1 suites   1 646 💤
     1 files         0 ❌

Results for commit f2140ee.

♻️ This comment has been updated with latest results.

@localstack localstack deleted a comment from github-actions bot May 19, 2025
Copy link

Test Results - Preflight, Unit

21 601 tests   19 955 ✅  6m 23s ⏱️
     1 suites   1 646 💤
     1 files         0 ❌

Results for commit f2140ee.

Copy link

Test Results - Alternative Providers

587 tests   407 ✅  14m 45s ⏱️
  4 suites  180 💤
  4 files      0 ❌

Results for commit f2140ee.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 41m 46s ⏱️ - 3m 28s
4 452 tests ±0  4 067 ✅ ±0  385 💤 ±0  0 ❌ ±0 
4 454 runs  ±0  4 067 ✅ ±0  387 💤 ±0  0 ❌ ±0 

Results for commit f2140ee. ± Comparison against base commit fa0bbcd.

Copy link

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   2h 21m 59s ⏱️
4 807 tests 4 247 ✅ 538 💤 0 ❌ 22 🔥
4 813 runs  4 247 ✅ 544 💤 0 ❌ 22 🔥

For more details on these errors, see this check.

Results for commit f2140ee.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 16s ⏱️
4 807 tests 4 269 ✅ 538 💤 0 ❌
4 813 runs  4 269 ✅ 544 💤 0 ❌

Results for commit f2140ee.

@silv-io silv-io added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label May 20, 2025
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and workflow summaries 🤩

@@ -93,7 +93,7 @@ start: ## Manually start the local infrastructure for testing
docker-run-tests: ## Initializes the test environment and runs the tests in a docker container
docker run -e LOCALSTACK_INTERNAL_TEST_COLLECT_METRIC=1 --entrypoint= -v `pwd`/.git:/opt/code/localstack/.git -v `pwd`/requirements-test.txt:/opt/code/localstack/requirements-test.txt -v `pwd`/tests/:/opt/code/localstack/tests/ -v `pwd`/dist/:/opt/code/localstack/dist/ -v `pwd`/target/:/opt/code/localstack/target/ -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/localstack:/var/lib/localstack \
$(IMAGE_NAME):$(DEFAULT_TAG) \
bash -c "make install-test && DEBUG=$(DEBUG) PYTEST_LOGLEVEL=$(PYTEST_LOGLEVEL) PYTEST_ARGS='$(PYTEST_ARGS)' COVERAGE_FILE='$(COVERAGE_FILE)' TEST_PATH='$(TEST_PATH)' LAMBDA_IGNORE_ARCHITECTURE=1 LAMBDA_INIT_POST_INVOKE_WAIT_MS=50 TINYBIRD_PYTEST_ARGS='$(TINYBIRD_PYTEST_ARGS)' TINYBIRD_DATASOURCE='$(TINYBIRD_DATASOURCE)' TINYBIRD_TOKEN='$(TINYBIRD_TOKEN)' TINYBIRD_URL='$(TINYBIRD_URL)' CI_REPOSITORY_NAME='$(CI_REPOSITORY_NAME)' CI_WORKFLOW_NAME='$(CI_WORKFLOW_NAME)' CI_COMMIT_BRANCH='$(CI_COMMIT_BRANCH)' CI_COMMIT_SHA='$(CI_COMMIT_SHA)' CI_JOB_URL='$(CI_JOB_URL)' CI_JOB_NAME='$(CI_JOB_NAME)' CI_JOB_ID='$(CI_JOB_ID)' CI='$(CI)' TEST_AWS_REGION_NAME='${TEST_AWS_REGION_NAME}' TEST_AWS_ACCESS_KEY_ID='${TEST_AWS_ACCESS_KEY_ID}' TEST_AWS_ACCOUNT_ID='${TEST_AWS_ACCOUNT_ID}' make test-coverage"
bash -c "make install-test && DEBUG=$(DEBUG) PYTEST_LOGLEVEL=$(PYTEST_LOGLEVEL) PYTEST_ARGS='$(PYTEST_ARGS)' COVERAGE_FILE='$(COVERAGE_FILE)' JUNIT_REPORTS_FILE=$(JUNIT_REPORTS_FILE) TEST_PATH='$(TEST_PATH)' LAMBDA_IGNORE_ARCHITECTURE=1 LAMBDA_INIT_POST_INVOKE_WAIT_MS=50 TINYBIRD_PYTEST_ARGS='$(TINYBIRD_PYTEST_ARGS)' TINYBIRD_DATASOURCE='$(TINYBIRD_DATASOURCE)' TINYBIRD_TOKEN='$(TINYBIRD_TOKEN)' TINYBIRD_URL='$(TINYBIRD_URL)' CI_REPOSITORY_NAME='$(CI_REPOSITORY_NAME)' CI_WORKFLOW_NAME='$(CI_WORKFLOW_NAME)' CI_COMMIT_BRANCH='$(CI_COMMIT_BRANCH)' CI_COMMIT_SHA='$(CI_COMMIT_SHA)' CI_JOB_URL='$(CI_JOB_URL)' CI_JOB_NAME='$(CI_JOB_NAME)' CI_JOB_ID='$(CI_JOB_ID)' CI='$(CI)' TEST_AWS_REGION_NAME='${TEST_AWS_REGION_NAME}' TEST_AWS_ACCESS_KEY_ID='${TEST_AWS_ACCESS_KEY_ID}' TEST_AWS_ACCOUNT_ID='${TEST_AWS_ACCOUNT_ID}' make test-coverage"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding JUNIT_REPORTS_FILE 🚀

with:
pattern: test-results-cloudformation-v2

- name: Download Cloudformation v2 Artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and some step names below must be renamed :)

@k-a-il k-a-il merged commit d3020f4 into master May 20, 2025
87 of 89 checks passed
@k-a-il k-a-il deleted the add-workflow-summaries branch May 20, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants