S3: fix IfMatch/IfNoneMatch in pre-signed URLs #12624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've got a report in our Community Slack that we were not enforcing the
IfNoneMatch
parameter with pre-signed URLs. After a quick investigation, it showed that boto3 was disregarding those parameters during the signing process, leading to us ignoring them and not passing them down to our parser; thus them not being enforced.This issue shows that Boto3 is not even passing those to the query string parameters of the pre-signed URL: boto/boto3#4367
Changes
botocore
because as reported in the boto GH issue, using botocore allows you to properly create a pre-signed URL with theIf-None-Match
header in the query string