-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
APIGW: add SQS X-Amz-JSON test #12649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results - Preflight, Unit21 601 tests 19 955 ✅ 6m 5s ⏱️ Results for commit 9bdc3c6. |
LocalStack Community integration with Pro 2 files 2 suites 18m 20s ⏱️ Results for commit 9bdc3c6. |
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 9s ⏱️ Results for commit 9bdc3c6. |
Test Results - Alternative Providers593 tests 413 ✅ 14m 49s ⏱️ Results for commit 9bdc3c6. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 47s ⏱️ Results for commit 9bdc3c6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Awesome thanks for the added test! Good to expand our test suite for aws implementation! 💪
authorizationType="NONE", | ||
) | ||
|
||
# we need to inline the JSON object because VTL does not handle newlines very well :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 VTL Can be a pain like that!
"responseOverride": { | ||
"header": "" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
observation: 👀 status
is not present by default? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes apparently so! We should also add a test fetching the status if not been set, maybe it returns an empty string? I was also surprised by this... 👀
Motivation
Adding a test for a previously untested case to verify support for JSON protocol via APIGW in SQS.
This test also adds proper validation of what is available in the VTL context. It seems we don't have major parity issues except the known "not returning nested dict", should be fixable with a special type in Python, and the fact that we can access
requestOverride
andresponseOverride
and their default.Changes