fix CloudFormation SNS Subscribe with Region parameter #12676
Conversation
Test Results - Preflight, Unit21 579 tests ±0 19 927 ✅ ±0 6m 14s ⏱️ -2s Results for commit 300ca0c. ± Comparison against base commit a298730b. |
Test Results (amd64) - Acceptance7 tests ±0 5 ✅ ±0 3m 8s ⏱️ +2s Results for commit 300ca0c. ± Comparison against base commit a298730b. |
Test Results - Alternative Providers597 tests 420 ✅ 14m 46s ⏱️ Results for commit 300ca0c. |
| @@ -153,3 +156,23 @@ def update( | |||
| @staticmethod | |||
| def attr_val(val): | |||
| return json.dumps(val) if isinstance(val, dict) else str(val) | |||
|
|
|||
| @staticmethod | |||
| def _get_client( | |||
There was a problem hiding this comment.
In the future we should make this utility available to other resource providers.
There was a problem hiding this comment.
Agreed! We should probably have a simpler way to re-use the client_params, as I now have to access private attributes via request.aws_client_factory._client_creation_params, which isn't great. Maybe we should save them somewhere, I'm not sure 🤔
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 42m 4s ⏱️ - 2m 49s Results for commit 300ca0c. ± Comparison against base commit a298730b. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 22m 13s ⏱️ Results for commit 300ca0c. |
Motivation
As reported by #12670, we have an issue with cross-region subscriptions in CloudFormation for SNS.
This is because we need the client that does the subscription to be configured in the same region as the topic. This was for example an issue in CDK here: aws/aws-cdk#13707, solved by properly adding the
Regionparameter with aws/aws-cdk#17273We did not consider this parameter at all.
I'm solving this by properly creating a client in the right region manually before doing the
Subscribecall.However, this is quite hacky because CloudFormation does not expose an easy way to do that with the exact same client configuration as the exposed default factory.
I'm directly accessing internal to make sure I'm creating the exact same client, but this is not great.
I prefer that to using
connect_tohowever, because CloudFormation has a special client, and it takes into account all the proper credentials and not just theaccount_idandregion(access key, secret key and token).Changes
AWS::SNS::Subscription