Skip to content

test(esm/sqs): Skip resource intensive flaky SQS message override test #12681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

test(esm/sqs): Skip resource intensive flaky SQS message override test #12681

merged 1 commit into from
May 29, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

The case of reading 10 000 records in a single SQS call was made possible via a custom override header. While the functionality works, this is a resource intensive task requiring 10K records to be read into SQS, followed by invocations of a target lambda of up to 2.5K records at a time.

Hence, this test should only be run on particular runners that better cater for these memory/compute requirements.

Changes

  • Skips the case of 10 000 records being read and processed unless the TEST_PERFORMANCE environment variable is set.

@gregfurman gregfurman added this to the 4.5 milestone May 29, 2025
@gregfurman gregfurman self-assigned this May 29, 2025
@gregfurman gregfurman added aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) area: testing Testing Localstack labels May 29, 2025
@gregfurman gregfurman requested a review from anisaoshafi May 29, 2025 08:36
anisaoshafi
anisaoshafi approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@anisaoshafi anisaoshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being proactive, Greg 🚀

@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 19s ⏱️ -7s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 5b985f7. ± Comparison against base commit e10e769.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 5s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5b985f7. ± Comparison against base commit e10e769.

@github-actions GitHub Actions
Copy link

Test Results - Alternative Providers

597 tests   420 ✅  15m 0s ⏱️
  4 suites  177 💤
  4 files      0 ❌

Results for commit 5b985f7.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 19m 11s ⏱️ - 22m 59s
3 260 tests  - 1 209  2 973 ✅  - 1 108  287 💤  - 101  0 ❌ ±0 
3 262 runs   - 1 209  2 973 ✅  - 1 108  289 💤  - 101  0 ❌ ±0 

Results for commit 5b985f7. ± Comparison against base commit e10e769.

This pull request removes 1209 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
This pull request skips 1 test. 
tests.aws.services.lambda_.event_source_mapping.test_lambda_integration_sqs.TestSQSEventSourceMapping ‑ test_sqs_event_source_mapping_batch_size_override[10000]

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 15s ⏱️
4 824 tests 4 282 ✅ 542 💤 0 ❌
4 830 runs  4 282 ✅ 548 💤 0 ❌

Results for commit 5b985f7.

@gregfurman gregfurman merged commit 79b46be into master May 29, 2025
66 checks passed
@gregfurman gregfurman deleted the skip/esm/sqs-msg-override-test branch May 29, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisaoshafi anisaoshafi anisaoshafi approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

@gregfurman gregfurman

Labels
area: testing Testing Localstack aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @anisaoshafi