Skip to content

Change cleanup job condition in main pipeline in Github Actions #12693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k-a-il
Copy link
Contributor

@k-a-il k-a-il commented May 30, 2025

Motivation

Because docker image and lambda artifacts use a lot of Github storage space, we try to keep only the ones we actually need. I added a cleanup job a while ago, but it only runs if the push job succeeds. Since the push job was skipped, the cleanup job was skipped too.
This PR changes when the cleanup runs — now it will delete docker-image and lambda artifacts every time, except if earlier workflow jobs failed or were cancelled (this will allow to rerun failed jobs without needing to rerun the whole pipeline to regenerate the docker image or lambda artifacts)

Changes

  • Changed condition of cleanup job

@k-a-il k-a-il self-assigned this May 30, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label May 30, 2025
@k-a-il k-a-il added this to the 4.5 milestone May 30, 2025
Copy link

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 38s ⏱️ +30s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9f577b5. ± Comparison against base commit 1833df1.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9f577b5. ± Comparison against base commit 1833df1.

Copy link

Test Results - Alternative Providers

597 tests   420 ✅  14m 57s ⏱️
  4 suites  177 💤
  4 files      0 ❌

Results for commit 9f577b5.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 2s ⏱️
4 824 tests 4 282 ✅ 542 💤 0 ❌
4 830 runs  4 282 ✅ 548 💤 0 ❌

Results for commit 9f577b5.

@k-a-il k-a-il marked this pull request as ready for review May 30, 2025 15:04
@k-a-il k-a-il added the area: ci Running LocalStack in CI environments label May 30, 2025
@k-a-il k-a-il removed the request for review from dfangl May 30, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant