CloudFormation v2 Engine: Base Support for Fn::Base64 #12700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 21m 47s ⏱️ Results for commit bd846d9. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers986 tests 568 ✅ 22m 34s ⏱️ Results for commit bd846d9. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 4s ⏱️ Results for commit bd846d9. ♻️ This comment has been updated with latest results. |
simonrw
approved these changes
Jun 3, 2025
| @@ -109,7 +109,6 @@ def test_and_or_functions( | |||
| bucket_names = [b["Name"] for b in buckets["Buckets"]] | |||
| assert (bucket_name in bucket_names) == expected_bucket_created | |||
|
|
|||
| @pytest.mark.skip(reason="CFNV2:Fn::Base64") | |||
| if not isinstance(string, str): | ||
| raise RuntimeError(f"Invalid valueToEncode for Fn::Base64: '{string}'") | ||
|
|
||
| string_bytes = string.encode("ascii") |
There was a problem hiding this comment.
question: is the string guaranteed to be ascii?
There was a problem hiding this comment.
Indeed, thanks, this should have just been ported from v1, I'll change it accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for
Fn::Base64.Changes