Add missing switch for forcing ARM tests on workflow dispatch #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

silv-io merged 2 commits into master from gha-force-arm-tests

Jun 4, 2025

Member

silv-io commented Jun 4, 2025 •

edited

Loading

Motivation

The GHA workflow only runs ARM tests on master and the dependency upgrade PRs, or when input.forceARMTests is set to true. However, we do not have that input. This PR adds that

Changes

Add forceARMTests input to both the main pipeline as well as the test sub-pipeline
Fix minor typo in Acceptance test job name

Testing

Test run with force ARM tests:
https://github.com/localstack/localstack/actions/runs/15441275724

TODO

What's left to do:

Fix workflow summary reporting after merging this (Fix Workflow summaries for ARM workflows #12707)
...


          Add missing switch for forcing ARM tests on workflow dispatch

18c5a43

github-actions bot commented Jun 4, 2025 •

edited

Loading

Test Results (MA/MR) - Preflight, Unit

21 595 tests ±0 19 940 ✅ ±0 6m 18s ⏱️ +5s
1 suites ±0 1 655 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 37be7ca. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

github-actions bot commented Jun 4, 2025 •

edited

Loading

Test Results - Preflight, Unit

21 595 tests ±0 19 940 ✅ ±0 6m 31s ⏱️ +20s
1 suites ±0 1 655 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 37be7ca. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

github-actions bot commented Jun 4, 2025 •

edited

Loading

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 6s ⏱️ -17s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

github-actions bot commented Jun 4, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests ±0 5 ✅ ±0 3m 13s ⏱️ ±0s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

github-actions bot commented Jun 4, 2025

Test Results - Alternative Providers

986 tests ±0 568 ✅ ±0 22m 28s ⏱️ -21s
4 suites ±0 418 💤 ±0
4 files ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

github-actions bot commented Jun 4, 2025

Test Results (MA/MR) - Alternative Providers

986 tests ±0 568 ✅ ±0 22m 27s ⏱️ -3s
4 suites ±0 418 💤 ±0
4 files ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

github-actions bot commented Jun 4, 2025

Test Results (amd64) - Integration, Bootstrap

5 files ±0 5 suites ±0 2h 21m 48s ⏱️ -12s
5 225 tests ±0 4 297 ✅ ±0 928 💤 ±0 0 ❌ ±0
5 231 runs ±0 4 297 ✅ ±0 934 💤 ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

github-actions bot commented Jun 4, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

5 files ±0 5 suites ±0 2h 23m 43s ⏱️ + 3m 12s
5 225 tests ±0 4 297 ✅ ±0 928 💤 ±0 0 ❌ ±0
5 231 runs ±0 4 297 ✅ ±0 934 💤 ±0 0 ❌ ±0

Results for commit 18c5a43. ± Comparison against base commit 8b3dcdd.

silv-io added the semver: patch label

silv-io added this to the 4.5 milestone


          Fix typo in acceptance test title

37be7ca

silv-io added the review: merge when ready label

silv-io marked this pull request as ready for review

June 4, 2025 12:02

silv-io requested review from alexrashed, dfangl, dominikschubert and k-a-il as code owners

June 4, 2025 12:02

k-a-il approved these changes

View reviewed changes

Contributor

k-a-il left a comment

LGTM

Member Author

silv-io commented Jun 4, 2025

Merging because the tests are not affected by this

silv-io merged commit 24c8538 into master

55 of 57 checks passed

silv-io deleted the gha-force-arm-tests branch

June 4, 2025 12:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

k-a-il k-a-il approved these changes

alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

dfangl Awaiting requested review from dfangl dfangl is a code owner

dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Labels

review: merge when ready semver: patch