Skip to content

GH Actions:change test selection parameter #12710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 5, 2025
Merged

GH Actions:change test selection parameter #12710

merged 7 commits into from
Jun 5, 2025

Conversation

k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Jun 4, 2025

Motivation

This PR corrects the condition for applying test selection. Test selection should be enabled for pull requests, while it remains disabled by default for manual and scheduled runs.

Changes

  • Changed condition of parameter disableTestSelection which is propagated to aws-tests.yml

@k-a-il k-a-il requested a review from silv-io June 4, 2025 09:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 595 tests  ±0   19 940 ✅ ±0   6m 11s ⏱️ ±0s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 472ffcb. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ -15s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 472ffcb. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results - Alternative Providers

986 tests  ±0   568 ✅ ±0   21m 32s ⏱️ - 1m 17s
  4 suites ±0   418 💤 ±0 
  4 files   ±0     0 ❌ ±0 

Results for commit 472ffcb. ± Comparison against base commit 8b3dcdd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 21m 44s ⏱️ -16s
5 227 tests +2  4 299 ✅ +2  928 💤 ±0  0 ❌ ±0 
5 233 runs  +2  4 299 ✅ +2  934 💤 ±0  0 ❌ ±0 

Results for commit 472ffcb. ± Comparison against base commit 8b3dcdd.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
tests.bootstrap.test_strict_service_loading ‑ test_strict_service_loading

tests.bootstrap.test_service_loading ‑ test_eager_and_strict_service_loading
tests.bootstrap.test_service_loading ‑ test_eager_service_loading
tests.bootstrap.test_service_loading ‑ test_strict_service_loading

♻️ This comment has been updated with latest results.

@k-a-il k-a-il self-assigned this Jun 4, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label Jun 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 41m 9s ⏱️ -48s
4 870 tests ±0  4 094 ✅ ±0  776 💤 ±0  0 ❌ ±0 
4 872 runs  ±0  4 094 ✅ ±0  778 💤 ±0  0 ❌ ±0 

Results for commit 28b4432. ± Comparison against base commit 8b3dcdd.

@k-a-il k-a-il marked this pull request as ready for review June 4, 2025 14:21
k-a-il
k-a-il commented Jun 4, 2025
View reviewed changes
.github/workflows/aws-main.yml
@@ -76,7 +76,7 @@ jobs:
# default "disableCaching" to `false` if it's a push or schedule event
disableCaching: ${{ inputs.disableCaching == true }}
# default "disableTestSelection" to `true` if it's a push or schedule event
disableTestSelection: ${{ inputs.enableTestSelection != true }}
disableTestSelection: ${{ (inputs.enableTestSelection != '' && inputs.enableTestSelection) || github.event_name == 'push' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputs.enableTestSelection will be an empty string if the workflow is triggered automatically. I think this deifinition version (inputs.enableTestSelection != '' && inputs.enableTestSelection) makes our intentions clearer: use the input value if it's defined, or use the push event as a fallback.

@tiurin tiurin added this to the Playground milestone Jun 4, 2025
silv-io
silv-io approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-a-il k-a-il merged commit 986ed8b into master Jun 5, 2025
63 of 64 checks passed
@k-a-il k-a-il deleted the gh-actions-test-selection branch June 5, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@k-a-il k-a-il

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
3 participants
@k-a-il @silv-io @tiurin