Skip to content

test(esm/sqs): Skip flaky test_report_batch_item_failures test #12713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

test(esm/sqs): Skip flaky test_report_batch_item_failures test #12713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_sqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,9 @@ def receive_dlq():


@markers.aws.validated
@pytest.mark.skip(
reason="Flaky as an SQS queue will not always return messages in a ReceiveMessages call."
)
def test_report_batch_item_failures(
create_lambda_function,
sqs_create_queue,
Expand Down Expand Up @@ -538,6 +541,7 @@ def test_report_batch_item_failures(
# now wait for the first invocation result which is expected to have processed message 1 we wait half the retry
# interval to wait long enough for the message to appear, but short enough to check that the DLQ is empty after
# the first attempt.
# FIXME: We cannot assume that the queue will always return a message in the given time-interval.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we can use the collect sqs messages fixture doing retries. Good catch 👍

first_invocation = aws_client.sqs.receive_message(
QueueUrl=destination_url, WaitTimeSeconds=int(retry_timeout / 2), MaxNumberOfMessages=1
)
Expand Down
Loading