Skip to content

SES: add snapshot test for describe_configuration_set with SNS destinations #12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

SES: add snapshot test for describe_configuration_set with SNS destinations #12814

wants to merge 1 commit into from

Conversation

dmacvicar
Copy link
Contributor

@dmacvicar dmacvicar commented Jun 29, 2025 •
edited
Loading

Motivation

As reported in #12722, describe_configuration_set is missing SNS event destinations.

This is addressed in getmoto/moto#9023 and this PR complements the parity enhancement with a snapshot test.

Changes

Only tests.

Testing

  • Snapshot test to validate the destinations are there when setting them for a configuration set.

TODO

@dmacvicar dmacvicar self-assigned this Jun 29, 2025
@dmacvicar dmacvicar added the semver: patch Non-breaking changes which can be included in patch releases label Jun 29, 2025
@localstack-bot
Copy link
Contributor

localstack-bot commented Jun 29, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed Jun 29, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from f699351 to 7684f3a Compare June 29, 2025 14:37
@dmacvicar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Jun 29, 2025
@localstack-bot
@dmacvicar has signed the CLA in #12814
8f50364
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   2m 47s ⏱️
168 tests 162 ✅ 5 💤 1 ❌
170 runs  162 ✅ 7 💤 1 ❌

For more details on these failures, see this check.

Results for commit aa59f83.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 25s ⏱️ +2s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit aa59f83. ± Comparison against base commit 31209be.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit aa59f83. ± Comparison against base commit 31209be.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   12m 4s ⏱️
192 tests 186 ✅  5 💤 1 ❌
198 runs  186 ✅ 11 💤 1 ❌

For more details on these failures, see this check.

Results for commit aa59f83.

♻️ This comment has been updated with latest results.

@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from 7684f3a to 67618e2 Compare June 29, 2025 20:41
@alexrashed alexrashed added this to the 4.8 milestone Jul 23, 2025
@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from 67618e2 to aa59f83 Compare August 20, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni viren-nadkarni will be requested when the pull request is marked ready for review viren-nadkarni is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmacvicar dmacvicar

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@dmacvicar @localstack-bot @alexrashed