S3: fix Access-Control-Allow-Headers handling in S3 CORS #12841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 25m 54s ⏱️ Results for commit c3fef77. ♻️ This comment has been updated with latest results. |
8b77c66 to
c3fef77
Compare
LocalStack Community integration with Pro 2 files 2 suites 1h 4m 22s ⏱️ Results for commit c3fef77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #12835, we had bad handling of comma separated values in the
Access-Control-Allow-Headersheader when handling CORS.This PR adds a small fix for that, along with a test
Changes
Access-Control-Allow-Headersbefore checking if it matches the S3 CORS Rulefixes #12835