S3: fix Checksum behavior for GetObject with PartNumber #12842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 26m 21s ⏱️ Results for commit 548a460. ♻️ This comment has been updated with latest results. |
100014e to
548a460
Compare
LocalStack Community integration with Pro 2 files 2 suites 1h 3m 32s ⏱️ Results for commit 548a460. |
k-a-il
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported by #12840, we did not return the right Checksum when calling
GetObjectwithPartNumberwhen the multipart upload was created with aCOMPOSITEchecksum type. It should have returned the part checksum. But if the objects were made of several parts, it would have returned no checksum at all. If the object only had one part, it would have returned the object checksum, which was wrong.This PR fixes the behavior. As a side-note, it seems S3 has quite special cases around checksums, and since they implemented
COMPOSITE&FULL_OBJECT, the codebase became quite a bit more complex 😕Changes
ChecksumType=COMPOSITE, properly return the part checksum when requested withGetObjectandHeadObjectCOMPOSITEandFULL_OBJECTCOMPOSITEreturns the part checksum and not the composite checksum of the objectFULL_OBJECTreturns the part checksum which is equal to the object checksumCOMPOSITEandFULL_OBJECTCOMPOSITEreturns the part checksumFULL_OBJECTdoes not return the part checksum, even though thelist_partscall earlier showed the part had a checksumfixes #12840