Es/fix Terraform domain deploy #12843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 59s ⏱️ Results for commit 1310437. ♻️ This comment has been updated with latest results. |
7424e6e to
1310437
Compare
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 43m 6s ⏱️ -37s Results for commit 1310437. ± Comparison against base commit 10e25f6. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
silv-io
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reported by a customer, creating a elasticsearch domain would fail unsing Terraform. The Terraform provider was looking for
DomainProcessingStatus=Active. Since this property was not returned by LocalStack the apply would immediately fail.This pr starts the implementation of
DomainProcessingStatusthrough the Domain lifecycle.As I was testing with Terraform, I noticed that most values provided by the user were not being added to the created resource, we would instead only add the default value. This would create issue on subsequent applies. There is still much to do to have CRUD layer parity AWS, but I started the process of at least using the user's value when creating the original
DomainStatus.Changes
test_create_domainto a validatedtest_domain_lifecycletestsDomainProcessingStatusthough the Domain lifecycleget_domain_statusto use the user request to improve it's default values