Docker: Add 'log_handler'-argument to pull() #12848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the images that we're downloading to support our emulation are quite large, so I've been considering a way to show more info to the user about what's happening in the background.
This PR adds an additional argument,
log_handler
to thedocker_client.pull(..)
method, allowing service developers to inspect (or log) the exact output of thepull
-command.Example invocation
For example, to stream the logs to user (probably the most common usecase for this):