Skip to content

Increase AWS CLI lower bound version to shorten resolution time #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Jul 11, 2025

Motivation

In some circumstances, when other packages with large dependencies install this package, they can have a large resolution tree because of the large amount of awscli versions we allow in the pyproject.toml in the runtime extras.

Changes

  • Up the lower bound for the awscli dependency in the runtime extra, to cut down the resolution tree for dependent projects. This is a safe upgrade because we know for both this project and the dependent one that a working resolution includes the latest version 1.41.3.

@silv-io silv-io requested a review from bentsku July 11, 2025 14:27
@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jul 11, 2025
@silv-io silv-io marked this pull request as ready for review July 11, 2025 14:34
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I believe this is a safe change, and something, as you mentioned, that we should probably automate. Thanks for taking of it 🧹

Copy link

Test Results - Preflight, Unit

21 854 tests  ±0   20 197 ✅ ±0   7m 6s ⏱️ +41s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1cab7fb. ± Comparison against base commit fc4c928.

@silv-io silv-io merged commit 2e48c23 into master Jul 11, 2025
20 of 21 checks passed
@silv-io silv-io deleted the fix-ext-build branch July 11, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants