introduce get-release-version in docker helper
#13006
Conversation
Helper Script Tests32 tests 32 ✅ 0s ⏱️ Results for commit abb4572. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Thanks, @eruditmorina for the contribution on the docker-helper!
I would love to learn more about your use case. Why do you need to source the helper? Right now the API is very clear and limited. Sourcing the script could mean that you might want to use functions that are not explicitly exposed via the API, which I would be very cautious about (because it might break at any point in time).
@alexrashed Currently we can make use of |
There was a problem hiding this comment.
Thanks! Honestly, that is actually pretty dangerous, there is a good chance that _is_release_commit might just be changed without any notice, I was actually shortly afraid we just broke your usage with #12943.
Please make an explicit operation and tests for it, which will make sure that we won't break your code without any notice or even knowledge about the usage.
It seems like you want to determine if your HEAD in currently a release, which sounds like a very useful extension to the script! Something like is-release?
get-release-version in docker helper
There was a problem hiding this comment.
Thanks a lot for jumping on the comments! 💯
The change is looking great, I think this makes it absolutely clear that this is a public API of the helper. I just added a comment concerning the exit code (which I think is quite important?). Happy to discuss / help / assist!
Motivation
HEADis a release tag viadocker-helper.sh.Changes
get-release-versioncommand which checks if commit is a release, and if so, outputs the version. Otherwise just a message telling that the commit is not a release.