Skip to content

CFNV2: implement NoEcho support #13011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

CFNV2: implement NoEcho support #13011

merged 2 commits into from
Aug 19, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 15, 2025 •
edited
Loading

Motivation

NoEcho allows sensitive parameter values to be masked in the the describe_ operations.

Note

This forms a stack on top of #13010

Changes

  • Implement enough to make the one test pass
  • Expand the test to make sure we understand the state changes when creating change sets for existing stacks

@simonrw simonrw mentioned this pull request Aug 15, 2025
Merged
@simonrw simonrw added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted labels Aug 15, 2025
@simonrw simonrw added this to the 4.8 milestone Aug 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 107 tests   - 33   20 372 ✅  - 33   6m 35s ⏱️ +16s
     1 suites ± 0    1 735 💤 ± 0 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 416e56c0. ± Comparison against base commit a69f74c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   21m 11s ⏱️
555 tests 330 ✅ 225 💤 0 ❌
557 runs  330 ✅ 227 💤 0 ❌

Results for commit 416e56c0.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 14s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 416e56c0. ± Comparison against base commit a69f74c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   33m 41s ⏱️ -15s
579 tests ±0  355 ✅ ±0  224 💤 ±0  0 ❌ ±0 
585 runs  ±0  355 ✅ ±0  230 💤 ±0  0 ❌ ±0 

Results for commit 416e56c0. ± Comparison against base commit a69f74c.

♻️ This comment has been updated with latest results.

@simonrw simonrw marked this pull request as ready for review August 15, 2025 15:28
@simonrw simonrw force-pushed the cfn/v2/implement-no-echo branch from ca51a61 to c4a009c Compare August 19, 2025 15:30
@simonrw simonrw force-pushed the cfn/v2/fix-remaining-transform-tests branch from 69dacbd to 875931e Compare August 19, 2025 16:00
@simonrw simonrw force-pushed the cfn/v2/implement-no-echo branch from c4a009c to 2db9745 Compare August 19, 2025 16:00
simonrw added 2 commits August 19, 2025 17:22
@simonrw
Remove _describe_change_set method
47a6c01 
It's only called once (unlike the `_describe_stacks` method) and it's
not very long, so let's inline it
@simonrw
Implement NoEcho
416e56c
@simonrw simonrw force-pushed the cfn/v2/fix-remaining-transform-tests branch from 875931e to a69f74c Compare August 19, 2025 16:24
@simonrw simonrw force-pushed the cfn/v2/implement-no-echo branch from 2db9745 to 416e56c Compare August 19, 2025 16:25
pinzon
pinzon approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pinzon pinzon merged commit a7f4742 into cfn/v2/fix-remaining-transform-tests Aug 19, 2025
38 checks passed
@pinzon pinzon deleted the cfn/v2/implement-no-echo branch August 19, 2025 18:09
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: implement NoEcho support (#13011)
976fad7
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: implement NoEcho support (#13011)
ab6f2d7
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: implement NoEcho support (#13011)
f9e466d
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: implement NoEcho support (#13011)
b990f66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@pinzon pinzon

Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @pinzon