Updated contribution guidelines link #13013
Conversation
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Thanks a lot for the contribution, @VanshikaSabharwal! You are absolutely right, the link to the org-wide contribution guides is confusing here in this repo, given that we have quite extensive repo-specific guidelines here.
Your change didn't quite hit the issue you explained (the bot message), but it's a good point to also add the guidelines to the issue template.
I pushed a small commit (126c26b) to adjust the bot message you have been referring to.
Now the PR is looking good to be merged! Could you please sign our CLA as described in this comment (just post the mentioned sentence without anything else as a comment to this PR)?
Thanks!
|
I have read the CLA Document and I hereby sign the CLA |
Yes. I am a new contributor to LocalStack, so I was finding it difficult to find the code for the bot, and thank you so much for helping me out. I am looking forward to contributing more and learn a lot. |
|
Awesome! Thanks a lot, congrats to your first contribution, and we are looking forward to your next one! 🤩 |
Motivation
Fixes:- #12907
The Contributing Guidelines link shown in issues is currently pointing to
https://github.com/localstack/.github/blob/main/CONTRIBUTING.md(incorrect).This confuses contributors since the actual contributing guide for LocalStack lives at
https://github.com/localstack/localstack/blob/main/docs/CONTRIBUTING.md.Changes
.github/ISSUE_TEMPLATE/config.ymlso that the "Contributing Guidelines" contact link points to the correct file inside thelocalstack/localstackrepository.Steps To Reproduce (before fix)
.github/blob/main/CONTRIBUTING.mdExpected Behavior (after fix)
The "Contributing Guidelines" link should point to:
https://github.com/localstack/localstack/blob/main/docs/CONTRIBUTING.mdEnvironment
docker runcommand (not relevant for this bug)Anything else?
N/A