Ruff linter: enable rule UP031 #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

giograno merged 3 commits into main from fix-up031

Aug 27, 2025

Member

giograno commented Aug 22, 2025 •

edited by alexrashed

Loading

Motivation

#12953 introduced the pyupgrade rules to our ruff linter.
However, a few rules have been ignored. This PR enabled UP031 and fixes the code accordingly.

giograno added this to the Playground milestone

giograno self-assigned this

giograno added semver: patch skip-docs labels

github-actions bot commented Aug 22, 2025 •

edited

Loading

S3 Image Test Results (AMD64 / ARM64)

2 files 2 suites 8m 3s ⏱️
517 tests 467 ✅ 50 💤 0 ❌
1 034 runs 934 ✅ 100 💤 0 ❌

Results for commit bd80e49.

♻️ This comment has been updated with latest results.

github-actions bot commented Aug 22, 2025 •

edited

Loading

Test Results - Preflight, Unit

22 159 tests ±0 20 422 ✅ ±0 6m 26s ⏱️ +4s
1 suites ±0 1 737 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit bd80e49. ± Comparison against base commit 5c5ba2a.

♻️ This comment has been updated with latest results.

github-actions bot commented Aug 22, 2025 •

edited

Loading

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 7s ⏱️ -2s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit bd80e49. ± Comparison against base commit 5c5ba2a.

♻️ This comment has been updated with latest results.

github-actions bot commented Aug 22, 2025 •

edited

Loading

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 2h 21m 49s ⏱️
5 003 tests 4 402 ✅ 601 💤 0 ❌
5 009 runs 4 402 ✅ 607 💤 0 ❌

Results for commit bd80e49.

♻️ This comment has been updated with latest results.

github-actions bot commented Aug 22, 2025 •

edited

Loading

LocalStack Community integration with Pro

2 files ±0 2 suites ±0 1h 43m 6s ⏱️ -37s
4 632 tests ±0 4 189 ✅ ±0 443 💤 ±0 0 ❌ ±0
4 634 runs ±0 4 189 ✅ ±0 445 💤 ±0 0 ❌ ±0

Results for commit bd80e49. ± Comparison against base commit 5c5ba2a.

♻️ This comment has been updated with latest results.

giograno marked this pull request as ready for review

August 22, 2025 16:45

giograno requested review from dominikschubert, thrau, baermat, gregfurman, bentsku, k-a-il, maxhoheiser, viren-nadkarni, pinzon, steffyP, simonrw, cloutierMat, dfangl, alexrashed, silv-io and sannya-singal as code owners

August 22, 2025 16:45

giograno removed request for simonrw, dominikschubert, thrau and viren-nadkarni

August 22, 2025 16:45

giograno removed request for steffyP, silv-io, maxhoheiser, dfangl, pinzon, gregfurman, sannya-singal, k-a-il, cloutierMat and baermat

August 22, 2025 16:45

alexrashed approved these changes

View reviewed changes

Member

alexrashed left a comment

Awesome! You can really see that with every rule exclusion being removed, the codebase gets cleaner and more modern! 💯
I didn't check the automatic changes (done by a safe ruff linting rule fixer), but the manual ones are looking good! 🦸🏽

giograno force-pushed the fix-up031 branch from 83574a6 to 166a324 Compare

August 26, 2025 10:30

giograno added 3 commits

August 26, 2025 19:46


          enable up031

f68c264


          fixes applicable by ruff with --unsafe-fix


          manual fixes

bd80e49

giograno force-pushed the fix-up031 branch from 166a324 to bd80e49 Compare

August 26, 2025 17:46

giograno merged commit de861e1 into main

47 checks passed

giograno deleted the fix-up031 branch

August 27, 2025 05:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch skip-docs