Fix typing for the tagging service #13077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Preflight, Unit22 117 tests 20 379 ✅ 7m 26s ⏱️ Results for commit 14c4fd6. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 9s ⏱️ Results for commit 14c4fd6. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 39s ⏱️ Results for commit 14c4fd6. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 43m 56s ⏱️ Results for commit 14c4fd6. ♻️ This comment has been updated with latest results. |
cd975e5 to
4b35eab
Compare
thrau
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR improves the type hints for the
TaggingServiceconstructor by making explicit the nullability of the arguments.py-avro-schemawould raise an error with the existing implementation since the arguments were not nullable (i.e., notstr | None) andNonewould not be a good default for a string.In cases like this,
mypywould raise an error:error: Incompatible default for argument "val" (default has type "None", argument has type "str") [assignment]).