Skip to content

fix CI step for publishing alternative providers results #13082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
+21 −2
Open

fix CI step for publishing alternative providers results #13082

Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
87a2832
fix alternative providers publishing not being executed
bentsku Sep 1, 2025
481946d
TODO: REMOVE, TRIGGER FOR PIPELINE
bentsku Sep 1, 2025
02d7505
Revert "TODO: REMOVE, TRIGGER FOR PIPELINE"
bentsku Sep 1, 2025
dec04db
debug
bentsku Sep 1, 2025
0517e78
debug
bentsku Sep 1, 2025
6516422
debug
bentsku Sep 1, 2025
193e5c3
debug? gotta love GH actions
bentsku Sep 1, 2025
eb5e9c5
(╯°□°)╯︵ ┻━┻
bentsku Sep 1, 2025
3a2b449
patience
bentsku Sep 1, 2025
a8ac708
patience again
bentsku Sep 1, 2025
7894b71
just trying things
bentsku Sep 1, 2025
c18309f
just trying things
bentsku Sep 2, 2025
f1f6a5f
try no parenthesis
bentsku Sep 2, 2025
a20b65b
debug
bentsku Sep 2, 2025
06f9c2a
replace checks manually
bentsku Sep 2, 2025
94f80a9
test trigger
bentsku Sep 2, 2025
8738665
fix events-v1 CI detection
bentsku Sep 2, 2025
2d6522e
improve all service detection
bentsku Sep 2, 2025
af4b5db
Revert "test trigger"
bentsku Sep 2, 2025
17a8c54
TBD: trying things out
bentsku Sep 4, 2025
5109396
Revert "Revert "test trigger""
bentsku Sep 4, 2025
0b468de
Revert "Revert "Revert "test trigger"""
bentsku Sep 4, 2025
a04930f
remove comments
bentsku Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions .github/workflows/aws-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,15 @@ jobs:
- 'localstack-core/localstack/services/cloudwatch/**'
- 'tests/aws/services/cloudwatch/**'
dynamodb-v2:
- 'localstack-core/localstack/services/dynamodb/**'
- 'tests/aws/services/dynamodb/**'
- 'tests/aws/services/dynamodbstreams/**'
- 'tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_dynamodbstreams.py'
events-v1:
- 'localstack-core/localstack/services/events/**'
- 'tests/aws/services/events/**'
cloudformation-v2:
- 'localstack-core/localstack/services/cloudformation/**'
- 'tests/aws/services/cloudformation/**'
sns-v2:
- 'tests/aws/services/sns/**' # todo: potentially add more locations (lambda/sqs tests?)
Expand Down Expand Up @@ -665,6 +668,9 @@ jobs:
# Set job-specific environment variables for pytest-tinybird
CI_JOB_NAME: ${{ github.job }}
CI_JOB_ID: ${{ github.job }}
outputs:
# we need this output to conditionally execute the Publishing step
job_status: "executed"
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -715,6 +721,9 @@ jobs:
# Set job-specific environment variables for pytest-tinybird
CI_JOB_NAME: ${{ github.job }}
CI_JOB_ID: ${{ github.job }}
outputs:
# we need this output to conditionally execute the Publishing step
job_status: "executed"
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -764,6 +773,9 @@ jobs:
# Set job-specific environment variables for pytest-tinybird
CI_JOB_NAME: ${{ github.job }}
CI_JOB_ID: ${{ github.job }}
outputs:
# we need this output to conditionally execute the Publishing step
job_status: "executed"
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -815,6 +827,9 @@ jobs:
# Set job-specific environment variables for pytest-tinybird
CI_JOB_NAME: ${{ github.job }}
CI_JOB_ID: ${{ github.job }}
outputs:
# we need this output to conditionally execute the Publishing step
job_status: "executed"
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -849,6 +864,7 @@ jobs:
${{ env.COVERAGE_FILE }}
${{ env.JUNIT_REPORTS_FILE }}
retention-days: 30

test-sns-v2:
name: Test SNS V2
if: ${{ !inputs.onlyAcceptanceTests && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v') || needs.test-preflight.outputs.sns-v2 == 'true') }}
Expand All @@ -861,6 +877,9 @@ jobs:
# Set job-specific environment variables for pytest-tinybird
CI_JOB_NAME: ${{ github.job }}
CI_JOB_ID: ${{ github.job }}
outputs:
# we need this output to conditionally execute the Publishing step
job_status: "executed"
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -901,6 +920,8 @@ jobs:

publish-alternative-provider-test-results:
name: Publish Alternative Provider Test Results
# execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped
if: ${{ !cancelled() && (contains(needs.*.outputs.job_status, 'executed')) }}
needs:
- test-cfn-v2-engine
- test-events-v1
Expand All @@ -913,8 +934,6 @@ jobs:
pull-requests: write
contents: read
issues: read
# execute on success or failure, but not if the workflow is cancelled or any of the dependencies has been skipped
if: always() && !cancelled() && !contains(needs.*.result, 'skipped')
steps:
- name: Download Cloudformation v2 Artifacts
uses: actions/download-artifact@v5
Expand Down
Loading