Skip to content

Fix misnamed service_name attribute in stores #13094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

Fix misnamed service_name attribute in stores #13094

merged 2 commits into from
Sep 4, 2025

Conversation

giograno
Copy link
Member

@giograno giograno commented Sep 3, 2025 •
edited by viren-nadkarni
Loading

Motivation

BaseStore annotates the service name as _service_name, but we are dynamically adding service_name.

See https://github.com/localstack/localstack-pro/pull/5186#discussion_r2318454469

Testing

Updates unit tests

@giograno giograno added this to the Playground milestone Sep 3, 2025
@giograno giograno added semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes labels Sep 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 117 tests  ±0   20 379 ✅ ±0   6m 35s ⏱️ +4s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3e55df3. ± Comparison against base commit f74d79b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3e55df3. ± Comparison against base commit f74d79b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 15s ⏱️
5 008 tests 4 406 ✅ 602 💤 0 ❌
5 014 runs  4 406 ✅ 608 💤 0 ❌

Results for commit 3e55df3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 48m 47s ⏱️ + 5m 27s
4 635 tests +3  4 192 ✅ +3  443 💤 ±0  0 ❌ ±0 
4 637 runs  +3  4 192 ✅ +3  445 💤 ±0  0 ❌ ±0 

Results for commit 3e55df3. ± Comparison against base commit f74d79b.

♻️ This comment has been updated with latest results.

@viren-nadkarni
Copy link
Member

This was originally prefixed with _ but was changed in 54ba905. I wonder why 🤔

@viren-nadkarni viren-nadkarni self-assigned this Sep 4, 2025
@viren-nadkarni viren-nadkarni changed the title Fix store's service name attribute Fix misnamed service_name attribute in stores Sep 4, 2025
@viren-nadkarni viren-nadkarni marked this pull request as ready for review September 4, 2025 11:43
@viren-nadkarni viren-nadkarni self-requested a review as a code owner September 4, 2025 11:43
viren-nadkarni
viren-nadkarni approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be an inadvertent change that went unnoticed for two years. New test assertion will make sure this won't happen again.

@giograno giograno merged commit 86a535f into main Sep 4, 2025
47 checks passed
@giograno giograno deleted the object-serializer-system branch September 4, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

@viren-nadkarni viren-nadkarni

@giograno giograno

Labels
semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@giograno @viren-nadkarni