Fix: Adding encoding for kinesis bytes input #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
reviewed
Feb 27, 2021
There was a problem hiding this comment.
Thanks for this PR @mgagliardo , great to tackle this issue. 👍 Added a few remarks/suggestions below - can you please review? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @whummer I found out my fix was mistaken on this comment: #3605 (comment) related to #3588
I have created these tests on the Java utils repo that match these new requirements. Sadly the only way I could find to fix this out is to "hack" the bytes and strip the double quotes and recreate the bytesarray or string (depending on each case).
Comments and requests as usual are welcome.