add new log output formatting and asf trace logging #6424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated view (changed HTML, changed logger names): |
dfangl
approved these changes
Jul 11, 2022
whummer
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Looks awesome, great set of changes @thrau @dfangl ! 💯
Just gave this a quick try with the SQS event source polling, and a few other use cases - nice approach with LS_LOG=trace and LS_LOG=trace-internal, so we don't need to manually define specific logger rules for the internal calls.. 👌 Excited to get this in!
| # x.x.x requires 5 = 2n - 1 characters | ||
| cur_length = (len(parts) * 2) - 1 | ||
|
|
||
| for i in range(len(parts)): |
| MAX_THREAD_NAME_LEN = 12 | ||
| MAX_NAME_LEN = 26 | ||
|
|
||
| LOG_FORMAT = f"%(asctime)s.%(msecs)03d %(ls_level)5s --- [%(ls_thread){MAX_THREAD_NAME_LEN}s] %(ls_name)-{MAX_NAME_LEN}s : %(message)s" |
There was a problem hiding this comment.
nit: Great to have the thread information also available in the logs, although potentially we could think about adding that to the trace-enabled logs only. Just a thought for future iterations, let's see how things are evolving with having the thread info in all logs for now.. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls log formatting and restructures the setup routine of the logs a bit
localstack.loggingformat.py)Not super happy with the
LS_LOG=trace|trace-internalsolution. But I did my best to use what was already there and not introduce additional/different configuration.LS_LOG=trace|trace-interalLS_LOG=trace-internalAWS sqs.ListQueues => 200), but we add in the same line the request dictionary and the headers (ListQueueRequest({}, headers={..http-headers..}), and the response also with the headers (ListQueueResponse(...)). this keeps everything neatly in one lineDemo
Here you can see trace logging in action: