Make SERVICES act as preload-list for EAGER_SERVICE_LOADING #6438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
Currently, SERVICES will deactivate certain service plugins - which leads to all sorts of problems, a lot of
if is_api_enableds over the codebase, and the bad practice to define SERVICES variable - often without taking in mind the interconnection of a lot of services.New behavior
SERVICES will lose all functionality if EAGER_SERVICE_LOADING=0. This should be without impact for most costumers (due to lazy loading), except for the warning message printed at startup.
SERVICES will now define a list of services preloaded with
EAGER_SERVICE_LOADING=1. If this is enabled, all services specified will be started on startup, everything else will be loaded on demand. There is no more failing of requests due to a service not specified inSERVICESService plugins cannot be disabled now, and are all enabled (but not necessarily loaded) by default.
Impact
Impact should be, in general, minimal, due to the default activation of lazy service loading. It should however reduce SERVICES-related support cases.
Future work