Skip to content

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jan 6, 2023

Implement AWS validated tests for #6882.

The fix was worked on in moto here (localstack/moto#65) but an issue with the tests prevented me for merging at the time. I will come back to this later on, but we can merge the added tests and skip for now.

@bentsku bentsku temporarily deployed to localstack-ext-tests January 6, 2023 14:46 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests January 6, 2023 15:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

LocalStack integration with Pro

1 881 tests   1 681 ✔️  1h 35m 15s ⏱️
       1 suites     200 💤
       1 files           0

Results for commit e1a4be8.

♻️ This comment has been updated with latest results.

@bentsku bentsku self-assigned this Jan 6, 2023
@bentsku bentsku added the aws:s3 Amazon Simple Storage Service label Jan 6, 2023
@bentsku bentsku changed the title wip: add tests for multipart SSE fields and S3 KMS BucketKeyEnabled add tests for multipart SSE fields and S3 KMS BucketKeyEnabled Mar 27, 2023
@bentsku bentsku marked this pull request as ready for review March 27, 2023 22:06
@bentsku bentsku requested a review from macnev2013 as a code owner March 27, 2023 22:06
@coveralls
Copy link

coveralls commented Mar 27, 2023

Coverage Status

Coverage: 81.964% (+0.002%) from 81.962% when pulling e1a4be8 on fix/6882 into 87d3895 on master.

Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, once the conflicts are resolved 👍🏻

@bentsku bentsku merged commit e77b681 into master Apr 17, 2023
@bentsku bentsku deleted the fix/6882 branch April 17, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:s3 Amazon Simple Storage Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants