Skip to content

Feature CFn Macros/Transformations #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Feb 16, 2023
Merged

Feature CFn Macros/Transformations #7509

merged 42 commits into from
Feb 16, 2023

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jan 17, 2023 •
edited
Loading

This PR adds supports for CFn Macros/Global Transformations. Several feature tests were added in a previous PR so the objective of this one is to make several of those tests pass.

Tests Passing:

  • test_macro_deployment
  • test_global_scope
  • test_capabilities_requirements
  • test_validate_lamba_internals
  • test_to_validate_template_limit
  • test_error_pass_macro_as_reference
  • test_functions_and_references_during_transformation.
  • test_failed_state

Notes:

  • the correct behaviours and errors messages need to be correctly defined for the update_stack and create_change_set operations.

@pinzon pinzon temporarily deployed to localstack-ext-tests January 17, 2023 14:52 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 42m 17s ⏱️ + 12m 3s
1 726 tests +1  1 377 ✔️ +10  349 💤  - 9  0 ❌ ±0 
2 440 runs  +1  1 751 ✔️ +10  689 💤  - 9  0 ❌ ±0 

Results for commit fb18022. ± Comparison against base commit 87557f4.

♻️ This comment has been updated with latest results.

@pinzon pinzon temporarily deployed to localstack-ext-tests January 17, 2023 20:15 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 19, 2023 17:25 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 19, 2023 18:45 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 19, 2023 18:56 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 19, 2023 19:32 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 20, 2023 14:29 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 20, 2023 15:46 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 20, 2023 17:32 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 20, 2023 20:13 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 23, 2023 18:21 — with GitHub Actions Inactive
@pinzon pinzon force-pushed the feat/cfn-global-transformations branch from 0903585 to f29fc9d Compare January 23, 2023 18:26
@pinzon pinzon temporarily deployed to localstack-ext-tests January 23, 2023 18:27 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 23, 2023 21:08 — with GitHub Actions Inactive
@pinzon pinzon marked this pull request as ready for review January 23, 2023 21:47
@pinzon pinzon temporarily deployed to localstack-ext-tests January 23, 2023 21:47 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 24, 2023 01:46 — with GitHub Actions Inactive
@pinzon pinzon force-pushed the feat/cfn-global-transformations branch from 048d55f to e57df9e Compare January 24, 2023 17:37
@pinzon pinzon temporarily deployed to localstack-ext-tests January 24, 2023 17:37 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 25, 2023 20:04 — with GitHub Actions Inactive
@pinzon pinzon requested a review from dfangl as a code owner January 25, 2023 20:20
@pinzon pinzon temporarily deployed to localstack-ext-tests January 25, 2023 20:21 — with GitHub Actions Inactive
@pinzon pinzon force-pushed the feat/cfn-global-transformations branch from c469d38 to e82798f Compare January 26, 2023 00:03
@pinzon pinzon temporarily deployed to localstack-ext-tests January 26, 2023 00:03 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 26, 2023 00:10 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 26, 2023 18:31 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 26, 2023 19:00 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests January 26, 2023 19:30 — with GitHub Actions Inactive
@pinzon pinzon force-pushed the feat/cfn-global-transformations branch from 0b4c57d to fb18022 Compare February 14, 2023 15:53
@pinzon pinzon temporarily deployed to localstack-ext-tests February 14, 2023 15:53 — with GitHub Actions Inactive
@pinzon pinzon temporarily deployed to localstack-ext-tests February 14, 2023 19:52 — with GitHub Actions Inactive
@pinzon pinzon merged commit ed74b27 into master Feb 16, 2023
@pinzon pinzon deleted the feat/cfn-global-transformations branch February 16, 2023 22:00
@dominikschubert dominikschubert mentioned this pull request Feb 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @dominikschubert