[SFN] base implementation of intrinsic functions #7526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est suite updates, lintings
dominikschubert
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
LGTM 👍
A few remarks:
-
We can probably remove the number of files a bit by aggregating them which would be a bit more pythonic in general. E.g. Keep all the different function_argument_x classes in
function_argument.py. This generally also makes reviewing, code navigation and refactoring in general a bit easier -
Do you think we should also verify the input argument types more? I'm not sure how stepfunction behaves when you for example try to add or multiply a number + string or when you have an array of non-string values. 🤔
| @@ -0,0 +1,27 @@ | |||
| from enum import Enum | |||
There was a problem hiding this comment.
file name has a typo (fuinction => function)
| @@ -404,10 +409,10 @@ def check_invocations(): | |||
| # clean up | |||
| cleanup(sm_arn, state_machines_before, stepfunctions_client) | |||
|
|
|||
| @pytest.mark.skip("Intrinsic Functions not yet supported.") | |||
| # @pytest.mark.skip("Intrinsic Functions not yet supported.") | |||
There was a problem hiding this comment.
this should probably just be deleted right?
Comment on lines
-409
to
+415
| if os.environ.get("AWS_DEFAULT_REGION") != "us-east-1": | ||
| pytest.skip("skipping non us-east-1 temporarily") | ||
| # if os.environ.get("AWS_DEFAULT_REGION") != "us-east-1": | ||
| # pytest.skip("skipping non us-east-1 temporarily") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds base: lexer, grammar, components, and implementation of stepfunctions' intrinsic functions.
Unrelated test failure:
tests/integration/stepfunctions/legacy/test_stepfunctions_legacy.py::test_aws_sdk_task_delete_s3_object