Skip to content

Improve support for request integration parameters #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 24, 2023
Merged

Improve support for request integration parameters #7580

merged 6 commits into from
Feb 24, 2023

Conversation

calvernaz
Copy link
Contributor

@calvernaz calvernaz commented Jan 31, 2023 •
edited
Loading

Improve support for request parameters.

Terraform Sample - https://github.com/localstack/localstack-terraform-samples/tree/master/apigateway-appsync-integration

Links to: #7729

@calvernaz calvernaz marked this pull request as draft January 31, 2023 11:26
@calvernaz calvernaz temporarily deployed to localstack-ext-tests January 31, 2023 11:26 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 31, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 29m 20s ⏱️ - 8m 39s
1 753 tests ±0  1 385 ✔️ +1  368 💤  - 1  0 ❌ ±0 
2 471 runs  ±0  1 761 ✔️ +1  710 💤  - 1  0 ❌ ±0 

Results for commit 4768d1a. ± Comparison against base commit 4be5754.

♻️ This comment has been updated with latest results.

@calvernaz calvernaz force-pushed the add-support-for-apigw-appsync-integration branch from abcad29 to c22d36a Compare February 20, 2023 01:00
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 20, 2023 01:00 — with GitHub Actions Inactive
@calvernaz calvernaz marked this pull request as ready for review February 20, 2023 01:02
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 20, 2023 01:19 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 20, 2023 •
edited
Loading

Coverage Status

Coverage: 85.036% (-0.02%) from 85.056% when pulling 4768d1a on add-support-for-apigw-appsync-integration into 4be5754 on master.

@calvernaz calvernaz requested review from joe4dev and whummer February 20, 2023 18:33
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 23, 2023 22:16 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 23, 2023 22:28 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 23, 2023 23:04 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 23, 2023 23:23 — with GitHub Actions Inactive
@calvernaz calvernaz changed the title Add support to Apigateway to AppSync integration Improve support for request integration parameters Feb 23, 2023
@calvernaz calvernaz force-pushed the add-support-for-apigw-appsync-integration branch from 3115358 to 13a6971 Compare February 24, 2023 09:17
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 09:17 — with GitHub Actions Inactive
whummer
whummer approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 10:00 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 10:01 — with GitHub Actions Inactive
joe4dev
joe4dev approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

just a few minor suggestions

@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 11:44 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 13:55 — with GitHub Actions Inactive
@calvernaz calvernaz temporarily deployed to localstack-ext-tests February 24, 2023 15:44 — with GitHub Actions Inactive
@calvernaz calvernaz merged commit d0c9a19 into master Feb 24, 2023
@calvernaz calvernaz deleted the add-support-for-apigw-appsync-integration branch February 24, 2023 17:17
@bentsku bentsku mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calvernaz @coveralls @whummer @joe4dev