Skip to content

Fix CFn Route53 Record Set TTL #7677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix CFn Route53 Record Set TTL #7677

merged 2 commits into from
Feb 13, 2023

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Feb 13, 2023

The TTL should be accepted either as a string or int.

Changes:

  • Convert attribute to integer if it's a string
  • Altered one test to validate the behavior
  • mark the test as AWS validated

@pinzon pinzon temporarily deployed to localstack-ext-tests February 13, 2023 19:38 — with GitHub Actions Inactive
@pinzon pinzon marked this pull request as ready for review February 13, 2023 19:38
dominikschubert
dominikschubert approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

LocalStack integration with Pro

       3 files  +    1         3 suites  +1   1h 29m 30s ⏱️ + 2m 24s
1 725 tests ±    0  1 367 ✔️ +    3  358 💤  -     3  0 ❌ ±0 
2 439 runs  +365  1 741 ✔️ +202  698 💤 +163  0 ❌ ±0 

Results for commit af8e640. ± Comparison against base commit 2985ef4.

@pinzon pinzon merged commit 37e9476 into master Feb 13, 2023
@alexrashed alexrashed deleted the fix-route53_ttl branch March 27, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@giograno giograno giograno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinzon @dominikschubert @giograno