Skip to content

fix internet gateway attrs #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix internet gateway attrs #7679

merged 3 commits into from
Feb 16, 2023

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Feb 13, 2023 •
edited
Loading

The Ref of the resource model is fixed now. This PR addresses #7665.

Changes:

  • Resource model implements the resource handler to store the InternetGatewayId as PhysicalResourceId
  • The resource model now uses the InternetGatewayId to fetch the state
  • Test to validate the changes.

@pinzon pinzon temporarily deployed to localstack-ext-tests February 13, 2023 22:20 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 13, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 32m 16s ⏱️ -13s
1 727 tests +2  1 369 ✔️ +3  358 💤  - 1  0 ❌ ±0 
2 441 runs  +2  1 743 ✔️ +3  698 💤  - 1  0 ❌ ±0 

Results for commit 556a7a5. ± Comparison against base commit 37e9476.

♻️ This comment has been updated with latest results.

@pinzon pinzon temporarily deployed to localstack-ext-tests February 14, 2023 15:42 — with GitHub Actions Inactive
@pinzon pinzon marked this pull request as ready for review February 14, 2023 16:04
@pinzon pinzon changed the title WIP fix internet gateway attrs fix internet gateway attrs Feb 14, 2023
dominikschubert
dominikschubert approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit regarding test marker

Kudos for adding both ref and GetAtt validation in the test 👍

tests/integration/templates/internet_gateway.yml
Comment on lines +17 to +18
Value:
Ref: Gateway
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something interesting to note: AWS claims this returns the "Name" which makes no sense for an AWS::EC2::InternetGateway 😅

@pinzon pinzon temporarily deployed to localstack-ext-tests February 15, 2023 15:38 — with GitHub Actions Inactive
@dominikschubert dominikschubert merged commit 66557b4 into master Feb 16, 2023
@dominikschubert dominikschubert deleted the fix-ec2_internet_gateway_atts branch February 16, 2023 21:30
@dominikschubert dominikschubert mentioned this pull request Feb 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @dominikschubert