Skip to content

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented Feb 14, 2023

The API for some services changed over time. Currently, we do not have linting/checks that verify that the arguments of overriden functions differ.

This PR changes the definition of the implemented functions in the corresponding provider.py. It only fixes the unexpected keyword argument error (as e.g. mentioned in issue #7654).

As source, I used the CircleCI output for the script capture_notimplemented_responses.py, which logs the "unexpected keyword argument" errors.

@steffyP steffyP temporarily deployed to localstack-ext-tests February 14, 2023 18:06 — with GitHub Actions Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 30m 11s ⏱️ - 8m 17s
1 726 tests ±0  1 368 ✔️ +1  358 💤  - 1  0 ±0 
2 440 runs  ±0  1 742 ✔️ +1  698 💤  - 1  0 ±0 

Results for commit e2d4082. ± Comparison against base commit 8a3ffe8.

@steffyP steffyP marked this pull request as ready for review February 21, 2023 14:27
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thrau thrau merged commit c8a478d into master Feb 21, 2023
@steffyP steffyP deleted the fix_unexpected_keywords branch February 21, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants