Skip to content

Change behavior of VtlTemplate to modify variable values in-place #7687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2023
Merged

Change behavior of VtlTemplate to modify variable values in-place #7687

merged 3 commits into from
Feb 15, 2023

Conversation

whummer
Copy link
Member

@whummer whummer commented Feb 14, 2023 •
edited
Loading

Change behavior of the VtlTemplate utility class to modify variable values in-place. This PR is a prerequisite for an upstream PR that enhances support for AppSync pipeline resolvers.

@whummer whummer requested a review from silv-io February 14, 2023 19:05
@whummer whummer temporarily deployed to localstack-ext-tests February 14, 2023 19:05 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 14, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 30m 29s ⏱️ + 2m 14s
1 726 tests ±0  1 368 ✔️ ±0  358 💤 ±0  0 ❌ ±0 
2 440 runs  ±0  1 742 ✔️ ±0  698 💤 ±0  0 ❌ ±0 

Results for commit 5d0db6c. ± Comparison against base commit 14675b0.

♻️ This comment has been updated with latest results.

silv-io
silv-io reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some comments regarding dicts and deepcopy.

@whummer whummer temporarily deployed to localstack-ext-tests February 15, 2023 09:37 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests February 15, 2023 09:45 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests February 15, 2023 09:49 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests February 15, 2023 09:51 — with GitHub Actions Inactive
@whummer whummer changed the title Add utility classes to support dict.put(..) in VTL templates Change behavior of the VtlTemplate utility class to modify variable values in-place Feb 15, 2023
@whummer whummer changed the title Change behavior of the VtlTemplate utility class to modify variable values in-place Change behavior of VtlTemplate to modify variable values in-place Feb 15, 2023
@whummer whummer requested a review from silv-io February 15, 2023 11:34
silv-io
silv-io approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whummer whummer merged commit ec7f21d into master Feb 15, 2023
@whummer whummer deleted the vtl-dict-put branch February 15, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whummer @silv-io